Set operators for UD60x18 and SD59x18

[Amxx]

Note: this can't pass checks until prettier supports user defined operators.

Closes #167.

[PaulRBerg]

Thanks, Hadrien! I will review this during the weekend.

Indeed, the link checks will pass only after prettier-plugin-solidity and @solidity-parser/parser add support for Solidity v0.8.19 and UDVT operators:

solidity-parser/parser#80

[fvictorio]

@PaulRBerg Let me know if that's urgent for you. I opened an issue in Prettier Solidity but didn't implement it yet.

[PaulRBerg]

Thanks, @fvictorio.

This is relatively urgent, indeed, as we're prepping up for an audit of a code base that uses PRBMath, and it would be great to have this PR merged in before the audit starts (we'd prefer to use UDVT operators).

[PaulRBerg]

Just finished reviewing this. Overall it looks pretty good!

Besides the alphabetical ordering issues mentioned below, there's just one other thing that needs to be added:

Duplicate the revert test in div and mul so that both the function and the operator are covered.

[PaulRBerg]

@Amxx I have just pushed a commit to address all points above myself.

I am just waiting for prettier-plugin-solidity to add support for Solidity v0.8.19, and then we can merge this.

[Amxx]

I did not realize that they were ordered alphabetically.

Note that the order I used for operator is the one provided by solidity in its documentation.
(ordering is transparent to me, I let you do how you prefer)

[PaulRBerg]

No worries! Thanks for the additional color.

[fvictorio]

Done: https://github.com/prettier-solidity/prettier-plugin-solidity/releases/tag/v1.1.3

[PaulRBerg]

Thank you so, so much, @fvictorio.

But now I just realized that the issue wasn't due to prettier-plugin-solidity, as I have recently moved this project to use forge fmt instead.

The issue is with Solhint :(

This command fails:

yarn solhint "{src,test}/**/*.sol"

Any chance you could also bump the Solidity parser in Solhint to fix this? 🙏

[PaulRBerg]

CI passed after upgrading to the latest version of Solhint. Merging now.

Thanks for your contribution, Hadrien!