Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call DeleteWebhook before starting the polling loop #94

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

PaulSonOfLars
Copy link
Owner

What

Call DeleteWebhook before starting the long polling loop, simplifying the long polling code.
Also, add a new DisableWebhookDeletion option, which allows you to manage webhook deletion yourself.

As a drive-by, improve docs and comments.

Impact

  • Are your changes backwards compatible? No - changed the GetUpdateOpts in the StartPolling method to use a pointer instead of a value.
  • Have you included documentation, or updated existing documentation? Yes
  • Do errors and log messages provide enough context? Yes

@PaulSonOfLars PaulSonOfLars force-pushed the paul/call-deletewebhook-before-polling branch from 6cfe48e to de94d34 Compare August 21, 2023 21:57
@PaulSonOfLars PaulSonOfLars merged commit 1e878f4 into v2 Aug 21, 2023
3 checks passed
@PaulSonOfLars PaulSonOfLars deleted the paul/call-deletewebhook-before-polling branch August 21, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant