Compiler warnings in output_pwm.cpp #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two warnings in output_pwm.cpp that were caused by the class defining the member variable block as volatile, but passed when it was going to release the block, it complained that you are passing it to a non-volatile... So cast the pointer as to remove the warning.
There appears like there is a timing window where we were enabling the IS2 Transmit before we enabled the DMA and also had not set the interrupt vector. So probably depending on what all is happening, we were running into cases where t5he QUEUE underrun was detected probably because of this. Changed it for the two PTS8211 classes, reran @mjs513 sektch on post 93 in pjrc forum thread on Dual Serial, RAWHID, Serial+Midi16+Audio and a few others and they all appear to now make noise
|
The PT8211 change has left the call to update_responsibility() in a different position relative to the DMA setup. Should we be concerned? |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paul, not a big deal but when building and debugging I try to remove all of the warnings if possible
There are two warnings in output_pwm.cpp that were caused by the class
defining the member variable block as volatile,
but passed when it was going to release the block, it complained that you are passing it to a non-volatile...
So cast the pointer as to remove the warning.
Sorry sort of combined the warnings fix with maybe fix for PTS8211