Have the getModifyTime/create... check for SDFat returning 0's #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If they return 0, we bail and return false. This implied that no date/time was found, and or calling code was blindly using the values like month of 255...
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PaulStoffregen @mjs513
If they return 0, we bail and return false. This implied that no date/time was found, and or calling code was blindly using the values like month of 255...
This avoids/fixes issue with the SD listfiles faulting if SDFat returned 0s for date and time we translate for example month to 255, which we index and try to print...
Feels cleaner than hacking it in the sketch code