Update SPI.h #1
Closed
Update SPI.h #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to change SPI settings in the DmaSpi library. As all data is private to SPISettings, I propose an extra method in SPIClass for that purpose (which is a friend of SPISettings and thus can access the internals). The DmaSpi handles one or more slaves between a single pair of beginTransaction() and endTransaction() calls, by letting a chip select class handle the cs signal and apply SPI settings.
|
I'm thinking this over again, I'm still not sure how SPI transactions should be done by the DmaSpi. Please look at this thread from time to time as it was started for exactly this reason (DmaSpi and SPI transactions): http://forum.pjrc.com/threads/26304-DMA-SPI-and-SPI-transactions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to change SPI settings in the DmaSpi library. As all data is private to SPISettings, I propose an extra method in SPIClass for that purpose (which is a friend of SPISettings and thus can access the internals).
The DmaSpi handles one or more slaves between a single pair of beginTransaction() and endTransaction() calls, by letting a chip select class handle the cs signal and apply SPI settings.