updateScreen() support using clip rectangle #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was not in place to allow the output to be clipped to the area in the current clip rectangle. Can speed up output considerably if used right.
Copied over the function calls from the ILI9341_t3n. There is maybe some more functions missing the updates. But also added in new code from ILI9341_t3n the code now that when you do writeRect it looks and only marks the dirty area for the bounding rectangle of changed pixels (which may be the whole thing
Use similar settings to what the Adafruit library uses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @PaulStoffregen @mjs513,
The ST77xx code did not have the code in place to support doing updateScreen from Frame buffer and have it only update the area within current clip rectangle, like some of the others do.
So added it. This does not yet include the code that figures out what areas of the display have been updated (dirty) and use that setting. not sure yet if that was added into all of the graphic primitives. Will check and see if I can simply add a few checks and sets, else need to merge in some more code.
Using the clip code to limit how much of the display gets updated can speed up things a lot in some cases.
Can merge nor or wait and see if we try to add in additional stuff.
Longer term may update these drivers to allow the clip code to work in the Asyn updates using DMA.
Now off to play