Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AudioMemoryNoForceUpdate() #651

Conversation

h4yn0nnym0u5e
Copy link
Contributor

Although most users will need audio updates working, for development purposes it's sometime helpful to disable them and run updates from within the sketch. This feature adds that capability back in, which was removed in commit 503cd9f

Although most users will need audio updates working, for development purposes it's sometime helpful to disable them and run updates from within the sketch. This feature adds that capability back in, which was removed in commit 503cd9f
@PaulStoffregen
Copy link
Owner

Why expand the public API to support this test scenario?

A test program can create a class which calls update_setup() from its constructor. Then it is responsible for updates. But if you want to manually update the library, just create a public function which calls update_all(), rather than calling it from hardware-based timing.

@h4yn0nnym0u5e
Copy link
Contributor Author

h4yn0nnym0u5e commented Aug 24, 2022

Why? To restore functionality to existing code, which will be broken by this change, in a fairly easy to use way.

But as I've noted on the forum, I think there will potentially be other nasty surprises arising from the change you put in, which this PR doesn't address, so there's not a lot of point pursuing it as-is.

@PaulStoffregen
Copy link
Owner

Let's find those nasty surprises...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants