Fix UK keyboard compile warning #680
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssilverman
force-pushed
the
fix-uk-keyboard-warning
branch
from
88f4ceb
to
5a33652
Compare
|
Note: I didn't modify the Teensy 2 code. I'm hesitant because I'm not certain how much change should be introduced there. |
ssilverman
force-pushed
the
fix-uk-keyboard-warning
branch
from
5a33652
to
bd434d5
Compare
|
I changed my mind and changed the Teensy 2 code. Let me know if this is a desirable thing. |
Because this keyboard defines KEYCODE_EXTRA00, usb_keyboard.c's unicode_to_keycode() can return a 16-bit quantity. See: https://forum.pjrc.com/threads/71926-Button-Press-detector?p=319143&viewfull=1#post319143
ssilverman
force-pushed
the
fix-uk-keyboard-warning
branch
from
bd434d5
to
43a6cf8
Compare
|
I just force pushed changing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this keyboard defines KEYCODE_EXTRA00, usb_keyboard.c's unicode_to_keycode() can return a 16-bit quantity.
See:
https://forum.pjrc.com/threads/71926-Button-Press-detector?p=319143&viewfull=1#post319143