Fix Teensy 4 Compilation with USB_DISABLED Flag #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed in 9208360, but is required for the dummy serial interface when compiling with the USB_DISABLED flag.
This is invoked by unused_interrupt_vector() and throws a linker error when USB_DISABLED is set. Declaring a dummy function here to avoid the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with 1.59 I discovered that Teensy 4.0 does not compile when the
USB_DISABLEDflag is set. This PR fixes that issue with two small corrections.First, a declaration for
serialEvent()is added to the dummySerialinterface block. This was removed during the serial event rework for 1.59, but should be present for the dummy interface.Second, a dummy
usb_isr()function definition was added for situations where the core is compiled with no USB endpoints defined (NUM_ENDPOINTS). This function is invoked by theunused_interrupt_vector()function instartup.c, and without a definition was causing a linker error.I haven't done any testing in hardware, but the core now compiles at least.