-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection.update is now Collection.set #297
Conversation
Collection.update is now Collection.set on Backbone 1.0.0
Need to change the documentation, package.json, etc. if we're changing the Backbone requirement. |
Agree. This is my first commit to this project and I wasn't aware of those changes. This will break support for Backbone < 1.0.0 so I do not think you want to pull this change yet. By the way, package.json requires Backbone ">=0.9.10" when it should really be ">=0.9.10 <1.0.0". I'll update that one too on a different pull request. I am starting to use Backbone-relational on my project and decided not just to open an issue report with new version of Backbone but to also provide a fix. Please let me know how can I help with the required changes for this change. |
Collection.update is now Collection.set on Backbone 1.0.0
Collection.update is now Collection.set on Backbone 1.0.0
index.html and package.json updated. |
Unfortunately this isn't the only change required to make Backbone-relational play nicely with Backbone 1.0. Some tests are failing for a few different reasons. |
I never said this was everything required to make it play nicely with 1.0.0. I'll see what else I can do to help on the process of making the upgrade. |
That's fine -- just was pointing out that this breaks tests so it can't be merged right now. |
This has gotten merged as part of #303 . |
Collection.update is now Collection.set on Backbone 1.0.0