Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection.update is now Collection.set #297

Closed
wants to merge 3 commits into from
Closed

Collection.update is now Collection.set #297

wants to merge 3 commits into from

Conversation

eruizdechavez
Copy link
Contributor

Collection.update is now Collection.set on Backbone 1.0.0

Collection.update is now Collection.set on Backbone 1.0.0
@philfreo
Copy link
Collaborator

Need to change the documentation, package.json, etc. if we're changing the Backbone requirement.

@eruizdechavez
Copy link
Contributor Author

Agree. This is my first commit to this project and I wasn't aware of those changes. This will break support for Backbone < 1.0.0 so I do not think you want to pull this change yet. By the way, package.json requires Backbone ">=0.9.10" when it should really be ">=0.9.10 <1.0.0". I'll update that one too on a different pull request.

I am starting to use Backbone-relational on my project and decided not just to open an issue report with new version of Backbone but to also provide a fix.

Please let me know how can I help with the required changes for this change.

Erick Ruiz de Chavez added 2 commits March 20, 2013 11:35
Collection.update is now Collection.set on Backbone 1.0.0 
Collection.update is now Collection.set on Backbone 1.0.0 
@eruizdechavez
Copy link
Contributor Author

index.html and package.json updated.

@philfreo
Copy link
Collaborator

Unfortunately this isn't the only change required to make Backbone-relational play nicely with Backbone 1.0. Some tests are failing for a few different reasons.

@eruizdechavez
Copy link
Contributor Author

I never said this was everything required to make it play nicely with 1.0.0.

I'll see what else I can do to help on the process of making the upgrade.

@philfreo
Copy link
Collaborator

That's fine -- just was pointing out that this breaks tests so it can't be merged right now.

@philfreo philfreo mentioned this pull request Mar 21, 2013
@PaulUithol
Copy link
Owner

This has gotten merged as part of #303 .

@PaulUithol PaulUithol closed this Mar 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants