Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lodash 4 compatibility #585

Merged
merged 7 commits into from Feb 4, 2019
Merged

Lodash 4 compatibility #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
43efa2f
Add an option to run the tests with lodash instead of underscore
jgonggrijp Feb 4, 2019
8052599
Make all tests pass with both Underscore and Lodash 4 (fix #561)
jgonggrijp Feb 4, 2019
1a8f291
Add the lodash variant of the test suite to the Travis build
jgonggrijp Feb 4, 2019
03853d2
Attempt to fix the Travis config (1)
jgonggrijp Feb 4, 2019
047dc1c
Attempt to fix the Travis config (2)
jgonggrijp Feb 4, 2019
e79a939
Update the documentation to reflect that Lodash >= 3 works
jgonggrijp Feb 4, 2019
8c0e37b
Mention the --lodash option in the CONTRIBUTING.md
jgonggrijp Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions .travis.yml
View file
Open in desktop
@@ -1,11 +1,12 @@
language: node_js
node_js:
- "4"
- "8"
before_install:
- npm install -g npm
- npm install -g karma-cli
- npm install -g karma-cli@1
script:
- npm test
- karma start --single-run --browsers PhantomJS --lodash
sudo: false
cache:
directories:
Expand Down
4 changes: 3 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Expand Up @@ -20,7 +20,7 @@ Before you submit your Pull Request ensure the following things are true for you
- How to setup [ESLint](http://eslint.org/docs/user-guide/integrations)
2. Your changes are branched off of `master`
3. You have added a test case for your changes or updated an existing test case
4. All test cases are passing
4. All test cases are passing, both with Underscore and Lodash

# Running Unit Tests
You can run tests using PhantomJS (headless) or a web browser (Chrome)
Expand All @@ -29,3 +29,5 @@ You can run tests using PhantomJS (headless) or a web browser (Chrome)
- To run tests in a browser:
1. Run `karma start --single-run`
2. Open Chrome and connect to the url it outputs

You can test with Lodash instead of Underscore by passing the `--lodash` option to `karma start` or `yarn test`.