Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lodash 4 compatibility (next) #586

Merged
merged 8 commits into from Feb 9, 2019
Merged

Conversation

jgonggrijp
Copy link
Contributor

This is #585 redone for the next branch.

Installing the packages seems to have altered dist/backbone-relational.js and dist/backbone-relational.js.map as a side effect (probably the build script). It was not clear to me whether this should be the case, nor whether the contents of dist should always reflect the latest version of the code.

What should have happened to those files? If necessary, I can add another commit, or change an earlier commit and force-push, or make a separate branch and submit a new PR.

@bpatram bpatram merged commit 1124d0d into PaulUithol:next Feb 9, 2019
@jgonggrijp
Copy link
Contributor Author

@bpatram Thanks for merging!

@pombadev
Copy link

pombadev commented Mar 18, 2019

Any timeline of releasing this? Instead of waiting for v0.11.0 or v0.12.0, would you consider releasing it?
Our company decided to update lodash to v4 and ever since this has been simply a major pain for us.

Please don't take it in a wrong way. I'm not demanding a release, just politely asking.
Thanks.

@bpatram
Copy link
Collaborator

bpatram commented Mar 18, 2019

@pjmp @jgonggrijp I haven't actually been added to the NPM package owners yet; stand by.


@PaulUithol Can you add me as an owner to the NPM package?

npm owner add bpatram backbone-relational (https://docs.npmjs.com/cli/owner)

@PaulUithol
Copy link
Owner

Hey, thanks for the ping - missed the email initially I think. Am traveling/don't have any dev on this machine, but there is an option to add 'maintainers' via npmjs.com - could you let me know if that works/is sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants