Update dependencies #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisChV
reviewed
Sep 11, 2023
| @@ -85,7 +83,9 @@ class PCacheImage extends ImageProvider<PCacheImage> { | |||
| return SynchronousFuture<PCacheImage>(this); | |||
| } | |||
|
|
|||
| // TODO(chrischv): Replace [DecoderCallback] with [ImageDecoderCallback] | |||
There was a problem hiding this comment.
FTR: After merge this PR, create an issue to keep track this TODO
ChrisChV
reviewed
Sep 11, 2023
There was a problem hiding this comment.
@juanleondev All looks good, could you please check the tests and coverage?
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 90.24% 92.62% +2.37%
==========================================
Files 5 5
Lines 123 122 -1
==========================================
+ Hits 111 113 +2
+ Misses 12 9 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ChrisChV
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
Screenshot
Closes #28