Skip to content

Commit

Permalink
[SPARK-29065][SQL][TEST] Extend EXTRACT benchmark
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

In the PR, I propose to extend `ExtractBenchmark` and add new ones for:
- `EXTRACT` and `DATE` as input column
- the `DATE_PART` function and `DATE`/`TIMESTAMP` input column

### Why are the changes needed?

The `EXTRACT` expression is rebased on the `DATE_PART` expression by the PR apache#25410 where some of sub-expressions take `DATE` column as the input (`Millennium`, `Year` and etc.) but others require `TIMESTAMP` column (`Hour`, `Minute`). Separate benchmarks for `DATE` should exclude overhead of implicit conversions `DATE` <-> `TIMESTAMP`.

### Does this PR introduce any user-facing change?

No, it doesn't.

### How was this patch tested?
- Regenerated results of `ExtractBenchmark`

Closes apache#25772 from MaxGekk/date_part-benchmark.

Authored-by: Maxim Gekk <max.gekk@gmail.com>
Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
  • Loading branch information
MaxGekk authored and PavithraRamachandran committed Sep 14, 2019
1 parent 1ad244e commit 2c08aff
Show file tree
Hide file tree
Showing 2 changed files with 161 additions and 177 deletions.
Loading

0 comments on commit 2c08aff

Please sign in to comment.