Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a DatabaseEntryValueObject for dataset accession #450

Open
1 task
arteymix opened this issue Oct 3, 2022 · 1 comment
Open
1 task

Use a DatabaseEntryValueObject for dataset accession #450

arteymix opened this issue Oct 3, 2022 · 1 comment
Assignees
@arteymix
Labels
cleanup Code reorganization and changes that should not impact functionality rest-api Issues or pull requests involving the RESTful API
Milestone
1.32.0

Comments

@arteymix
Copy link
Member

arteymix commented Oct 3, 2022

This would constitute a breaking change, so I cannot introduce this in the 1.28. We already use that VO for BioAssayValueObject, so there's no reason not to be consistent for datasets.

  • redefine externalDatabase and externalUri as those would become accessible from accession.externalDatabase.{name,uri}, and keep them for backward compatibility (to be marked as deprecated)
@arteymix arteymix added rest-api Issues or pull requests involving the RESTful API cleanup Code reorganization and changes that should not impact functionality labels Oct 3, 2022
@arteymix arteymix added this to the 1.29.0 milestone Oct 3, 2022
@arteymix
Copy link
Member Author

arteymix commented Oct 3, 2022

This model would be a great way of exposing platform versions/update metadata we want to introduce in #378.

@arteymix arteymix modified the milestones: 1.29.0, 1.30.0 Dec 5, 2022
@arteymix arteymix self-assigned this Mar 6, 2023
@arteymix arteymix modified the milestones: 1.30.0, 1.31.0 May 16, 2023
@arteymix arteymix modified the milestones: 1.31.0, 1.32.0 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arteymix arteymix

Labels
cleanup Code reorganization and changes that should not impact functionality rest-api Issues or pull requests involving the RESTful API
Projects
None yet
Milestone
1.32.0
Development

No branches or pull requests
1 participant
@arteymix