Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cli_filter doesn't support node feature definitions #21

Open
wdavey opened this issue Oct 31, 2023 · 1 comment
Open

The cli_filter doesn't support node feature definitions #21

wdavey opened this issue Oct 31, 2023 · 1 comment
Assignees

Comments

@wdavey
Copy link
Collaborator

wdavey commented Oct 31, 2023

This cli filter expects to be able to pull node features based on the name of a partition which means that using the --constraints syntax is null a void.
This means partitions that overlap are unsupported as their feature set will vary based on the nodes features.

Can this please be fixed as it restricts the use of a key design feature of Slurm?

@halfflat
Copy link
Collaborator

halfflat commented Oct 31, 2023

The filter does operate on the assumption that cpu counts, gpu counts and memory configuration are homogeneous in a partition in order to compute:

  1. memory per CPU (modified by SMT count) to use in the absence of an explicit memory request, as a workaround for a slurm buglimitation;
  2. CPU to GPU ratios to supply a --cpus-per-gpu value for proportional shared access on GPU partitions.

It relies on there being sensible values for DefMemPerCPU and DefMemPerGPU in the partition configuration.

Similarly, it doesn't support allocations with a list of requested partitions.

I think for heterogeneous partitions or partitions with configurations without these assumptions above it would be best to bypass the cli_filter. As far as I know, the only way to do that is to supply an alternative SLURM_CONF, but we could add a check for an environment variable that directs the filter to pass on options unfiltered if that would be useful in these cases.

@halfflat halfflat self-assigned this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants