Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

what's the reason the application notifies on disconnect? #92

Closed
cmonacaps opened this issue Nov 16, 2019 · 2 comments
Closed

what's the reason the application notifies on disconnect? #92

cmonacaps opened this issue Nov 16, 2019 · 2 comments

Comments

@cmonacaps
Copy link

I ask because I can't imagine a use case for that.

Maybe if I'm using the app and it disconnects I would want to know, but if I left it connected in the background, and here I'm guessing, this is how it happens in 99.9% of cases, and the server eventually kicks out the idle connection, what would I do in response to the notification? Connect it and then leave it idle again?
Paxa added a commit that referenced this issue Nov 17, 2019
@Paxa
Handle disconnects:
bf3adb7 
Show alert dialog only when postbird is focussed and current tab is active
Add icon when tab is disconnected
Avoid multiple dialogs when server stopped
Offer to reconnect in disconnected dialog
Solves #92
@Paxa
Copy link
Owner

Paxa commented Nov 17, 2019

Agree, reasons is it was easier to implement. Thanks for reporting

I made it nice:
Screen Shot 2019-11-18 at 01 16 32

And dialog is shown only when we actually use this tab, and can open again by clicking on "Disconnected" icon

@Paxa Paxa closed this as completed Nov 17, 2019
@cmonacaps
Copy link
Author

hey, thanks! will watch for that in forthcoming releases 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Paxa @cmonacaps