#682 fix: enter key confirms button edit #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chedieck
force-pushed
the
fix/enter-on-edit-prompts-delete
branch
from
2302acf
to
81908f8
Compare
Klakurka
previously approved these changes
Sep 20, 2023
chedieck
dismissed
Klakurka’s stale review
The merge-base changed after approval.
|
Conflicts. |
Klakurka
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #682
Depends on
Description
Fixes #682
Test plan
Try editing a button and pressing enter to submit the changes, should work on all fields except addresses & description where a line break happens instead.