Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#328] feat: refresh addresses on button edit #694

Merged
merged 1 commit into from
Sep 29, 2023
Merged

[#328] feat: refresh addresses on button edit #694

merged 1 commit into from
Sep 29, 2023

Conversation

chedieck
Copy link
Collaborator

@chedieck chedieck commented Sep 28, 2023 •
edited

Related to #328

Description

Solves #328.

Test plan

When editing a button, make sure that:

  • Editing out an address immediately removes its transactions from the button detail page,
  • Editing in an address immediately adds its transactions to the button detail page,
  • Editing some other paybutton detail (such as the name, for example) doesn't change the transactions (nor does it makes it flash/blink/refresh to the same thing).

@chedieck chedieck changed the title [#512] feat: refresh addresses on button edit [#328] feat: refresh addresses on button edit Sep 28, 2023
@Klakurka Klakurka merged commit b6f389f into master Sep 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klakurka Klakurka Klakurka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chedieck @Klakurka