Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#801): close div properly #807

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

lissavxo
Copy link
Collaborator

Related to #

Description

  • changed the example to close the div to avoid errors
  • added indentation to the code

Test plan

Open the project, run the build docker-compose up and check the button generator if the html example is closing the div properly

@lissavxo lissavxo marked this pull request as draft January 29, 2024 18:22
@Klakurka
Copy link
Member

How about removing the extra space line here?

image

Copy link
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment issues.

image

@Klakurka Klakurka marked this pull request as ready for review January 30, 2024 18:23
Copy link
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I found two other unrelated issues while testing that I've made tasks for: #809 and #810.

@Klakurka Klakurka merged commit cba4f98 into master Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants