Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#811] feat: address as string and remove redundant opreturn #821

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

chedieck
Copy link
Collaborator

Related to #811

Description

Some minor fixes to SimplifiedTransaction:

  • paymentId is made mandatory, as is message. It will just be empty if it doesn't exist.
  • redundant opReturn removed
  • address is sent as a string, not full address object.

Test plan

Build the client using PayButton/paybutton#387. Test if:

  • Triggers execute without erroring,
  • The client receives a tx and executes onSuccess /onTransaction without erroring.

@Klakurka Klakurka merged commit d8e8a94 into master Feb 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants