Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#349] chore: update storybook #351

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

chedieck
Copy link
Collaborator

@chedieck chedieck commented Jan 24, 2024

Related to #349

Description

Fixes #349 by updating storybook and addressing the migrations requirements posted at the migration guide.

Test plan

Make sure the storybook runs normally. For that:

  1. Go to the react/ folder
  2. Make sure you don't have cached containers (these names may differ in your machine):
    i. docker container stop client-paybutton-react-1
    ii. docker container rm client-paybutton-react-1
    iii. docker image rm client-paybutton-react
  3. Run docker-compose up and access the storybook in the browser, should be working.

@lissavxo
Copy link
Collaborator

Got these trying the steps you provided

image

@chedieck
Copy link
Collaborator Author

Got these trying the steps you provided

Indeed, I missed the step where is necessary to reinstall the yarn packages. Updated the description to include rm -rf node_modules && yarn on the react folder.

@lissavxo
Copy link
Collaborator

I tried what you suggested, and here I got the same issue.
this new step of removing node_modules does not affect anything because when we create the docker file we move the package.json and make a new install

@Klakurka Klakurka self-requested a review January 24, 2024 17:06
Copy link
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mine's the same:

image

@chedieck
Copy link
Collaborator Author

this new step of removing node_modules does not affect anything because when we create the docker file we move the package.json and make a new install

Yes, but by the same logic, the error you two are getting should not happen since the packages are being installed in the Dockerfile, so I don't know what is happening

Mine's the same:

I got the same error you two got when going to master and trying to build the old version. Means that when instantiating the docker container it is not updating the executables that should appear after running yarn (in your case, storybook is the executable for the new storybook version that is missing; in my case, start-storybook is the one for the old version that is missing`)
image

. I am investigating, should be fixed soon

@chedieck
Copy link
Collaborator Author

@lissavxo @Klakurka Could you guys try it again after docker system prune -af && docker volume prune -af && docker image prune -af? Something is being cached, is the way I found to make it go away.

@Klakurka
Copy link
Member

image

@lissavxo
Copy link
Collaborator

lissavxo commented Jan 25, 2024

@lissavxo @Klakurka Could you guys try it again after docker system prune -af && docker volume prune -af && docker image prune -af? Something is being cached, is the way I found to make it go away.

are you able to run yarn build or yarn dev from the react folder ?
I tried it and I got an error here, so outside docker the storybook still does not work for me.

can you try running yarn clean:build from the root path?

@chedieck
Copy link
Collaborator Author

I tried it and I got an error here, so outside docker the storybook still does not work for me.

What error are you getting?

@Klakurka
Copy link
Member

image

@chedieck
Copy link
Collaborator Author

@Klakurka should be fixed now, microbundle had to be updated too

Copy link
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build works now but I still can't get storybook to launch.

image

@Klakurka
Copy link
Member

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook not working
3 participants