Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Prevent cancellation of completed orders on transaction callback #86

Merged
merged 14 commits into from
Sep 28, 2019

Conversation

aait
Copy link
Collaborator

@aait aait commented Sep 14, 2019

Moves the updating of '_payex_transaction_status' and '_transaction_id' into the switch statement in transaction_callback to be able to see what status the transaction says the order should have and not updating the values if the order already is completed and the status in the current callback is cancel or failure.
@lakrisgubbenlakrisgubben

@aait aait added the bug label Sep 14, 2019
@aait aait self-assigned this Sep 14, 2019
Copy link
Contributor

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks ok, but there are no tests and the build is failing on Travis.

@aait aait merged commit 447a255 into master Sep 28, 2019
@aait aait deleted the hotfix/issue85 branch September 28, 2019 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants