Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGF-531: fix Dropdown props #105

Merged
merged 4 commits into from Nov 12, 2020
Merged

PGF-531: fix Dropdown props #105

merged 4 commits into from Nov 12, 2020

Conversation

OliviaGometz
Copy link
Contributor

@OliviaGometz OliviaGometz commented Nov 9, 2020 •
edited

  • Utilisation du rest et non des props sur le composant Dropdown
  • Passage à un switch plus lisible
  • Déplacement de l'instruction font-family dans le global.js (pour ne pas l'oublier quand on copie le style dans d'autres projets, sinon on n'a pas la bonne police)(rien à voir avec le Dropdown, c'était juste en passant)
  • Ajout d'options de positions pour la Popin (ce qui modifie légèrement la constante également utilisée pour les Message, d'où les modifications sur ses fichiers).

Toutes les modifications apportées dans cette PR sont rétro-compatibles (aucun changement à faire à l'intégration).

@OliviaGometz OliviaGometz merged commit 3fed3a1 into master Nov 12, 2020
@OliviaGometz OliviaGometz deleted the pgf-531-fix-dropdown-props branch November 12, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanya3 fanya3 fanya3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OliviaGometz @fanya3