PGF-533: improve texts lisibility #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OliviaGometz
commented
Nov 10, 2020
OliviaGometz
commented
- Amélioration de la lisibilité des Title et Text en reverse (blanc sur fond coloré) avec l'ajout d'un text-shadow
- Amélioration de la visibilité des Title avec le passage du grey60 comme gris par défaut
- Retrait de la propriété HTML "value" qui restait sur le DataLegend
- Clean du style du DataLegend (les em, c'est magique !)
- Refacto du système de minimizeFont (utilisation de constantes + optimisation des listes de valeurs utilisées dans les Title et Text)
fanya3
approved these changes
Nov 12, 2020
refacto: DataLegend style
OliviaGometz
force-pushed
the
pgf-533-improve-texts-lisibility
branch
from
0c0083f
to
656d7d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.