Added test-utils module, removed unnecessary complexity from tests #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becauase there's a tomcat port collision
becauase there's a tomcat port collision
test-utils Conflicts: test-utils/pom.xml test-utils/src/main/java/com/payu/ratel/tests/RatelIntegrationTestExecutionListener.java test-utils/src/main/java/com/payu/ratel/tests/RatelTest.java test-utils/src/main/java/com/payu/ratel/tests/RatelTestContext.java test-utils/src/main/java/com/payu/ratel/tests/TestRatelConfiguration.java tests/src/test/java/com/payu/ratel/tests/ClientCacheTest.java tests/src/test/java/com/payu/ratel/tests/ExceptionTransportTest.java tests/src/test/java/com/payu/ratel/tests/TracingMechanismTest.java
| @@ -49,6 +49,7 @@ | |||
| <dependency> | |||
| <groupId>org.assertj</groupId> | |||
| <artifactId>assertj-core</artifactId> | |||
| <version>1.7.0</version> | |||
There was a problem hiding this comment.
Better is having version in dependencymanagment in root project, we use this artifiact more then once
test-utils Conflicts: test-utils/pom.xml test-utils/src/main/java/com/payu/ratel/tests/RatelIntegrationTestExecutionListener.java test-utils/src/main/java/com/payu/ratel/tests/RatelTest.java test-utils/src/main/java/com/payu/ratel/tests/RatelTestContext.java test-utils/src/main/java/com/payu/ratel/tests/TestRatelConfiguration.java tests/src/test/java/com/payu/ratel/tests/ClientCacheTest.java tests/src/test/java/com/payu/ratel/tests/ExceptionTransportTest.java tests/src/test/java/com/payu/ratel/tests/TracingMechanismTest.java
…nto test-utils
|
dependency managment for assertj moved to parent pom. |
pgrela
added a commit
that referenced
this pull request
Apr 23, 2015
Added test-utils module, removed unnecessary complexity from tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.