Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of readOnly and writeOnly with anyOf/oneOf/allOf #32

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Support of readOnly and writeOnly with anyOf/oneOf/allOf #32

merged 2 commits into from
Jul 22, 2019

Conversation

kobik
Copy link
Collaborator

@kobik kobik commented Jul 21, 2019

Closes #31

@coveralls
Copy link

coveralls commented Jul 21, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 243

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 98.08%
Totals Coverage Status
Change from base Build 238: 0.05%
Covered Lines: 489
Relevant Lines: 491
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 241

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 98.08%
Totals Coverage Status
Change from base Build 238: 0.05%
Covered Lines: 489
Relevant Lines: 491
💛 - Coveralls

kobik
kobik commented Jul 21, 2019
View reviewed changes
src/utils/schemaUtils.js Outdated Show resolved Hide resolved
@kobik kobik requested review from idanto and kibertoad July 21, 2019 16:23
idanto
idanto approved these changes Jul 22, 2019
View reviewed changes
test/openapi3/general/readOnlyWriteOnly.yaml
post:
requestBody:
required: true
content:
application/json;utf8:
application/hal+json:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change it to hal?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that utf8 part should never be part of API spec, instead we should handle requests that include it in header as just application/json
Support for that is implemented here: #29

@kobik kobik merged commit bca1009 into master Jul 22, 2019
@kobik kobik deleted the support-readOnly-writeOnly-with-anyOf-oneOf-allOf branch July 22, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idanto idanto idanto approved these changes

@kibertoad kibertoad Awaiting requested review from kibertoad

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support of readOnly and writeOnly with anyOf/oneOf/allOf
4 participants
@kobik @coveralls @kibertoad @idanto