Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support external file refs #38

Merged
merged 10 commits into from
Dec 11, 2019
Merged

support external file refs #38

merged 10 commits into from
Dec 11, 2019

Conversation

kobik
Copy link
Collaborator

@kobik kobik commented Sep 18, 2019

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 293

  • 42 of 43 (97.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 97.482%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/schemaLoaders.js 23 24 95.83%
Totals Coverage Status
Change from base Build 290: -0.6%
Covered Lines: 551
Relevant Lines: 554

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 18, 2019

Pull Request Test Coverage Report for Build 307

  • 43 of 44 (97.73%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 97.562%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/schemaLoaders.js 22 23 95.65%
Totals Coverage Status
Change from base Build 290: -0.5%
Covered Lines: 1653
Relevant Lines: 1662

💛 - Coveralls

@kobik
Copy link
Collaborator Author

kobik commented Sep 22, 2019

@kibertoad, can you please review?

@kibertoad
Copy link
Collaborator

@kobik Sure, will do within a couple of hours.

src/utils/schemaUtils.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@kobik
Copy link
Collaborator Author

kobik commented Sep 25, 2019 via email

@kibertoad
Copy link
Collaborator

@kobik I think it was published: https://www.npmjs.com/package/json-schema-deref-sync

@kobik kobik marked this pull request as ready for review December 11, 2019 07:48
@kobik kobik merged commit 1ad8ddd into master Dec 11, 2019
@kobik kobik deleted the support-external-file-refs branch December 11, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants