Allow body validator to be created where possible #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The body validator was not getting created because the reference schema does not contain the requestPath which in turn is because the way external file is split (it moves all path of user to a separate file). As referencedBodySchema is not needed to create the validator that is needed I have relaxed the guard statement in handleBodyValidation().
Pull Request Test Coverage Report for Build 310
💛 - Coveralls |
kobik
approved these changes
Mar 19, 2020
|
Thanks! Would you be able to cut a release with this soon please? So I can go PR downstream packages that needs this change for supporting split swagger yaml files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The body validator was not getting created because the reference schema
does not contain the requestPath which in turn is because the way
external file is split (it moves all path of user to a separate file).
As referencedBodySchema is not needed to create the validator that is
needed I have relaxed the guard statement in handleBodyValidation().