-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fix for basic relative URLs in servers #67
Conversation
This adds support for basic relative URLs in servers * Note that this does not support variables/variable substitutions
This resolves #59 |
Can one of you please review and merge if it looks good? |
Any update on this fix? This PR resolves the relative path errors and all tests pass. It would be great if you can review, merge and release. |
Hi @dipsmishra, Thanks for the PR! I hope I'll have the time to look on the nezt couple of days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dipsmishra !
@dipsmishra can you please update CHANGELOG.md? |
Yes, sure. Should I update the version in package.json to 2.0.5 too? I am not entirely sure about your release process and hence, checking. |
No need to update the json file as I use 'npm version' command for bumping and tagging before publishing it |
Thanks for the clarification, @kobik - I have updated the PR accordingly and also pulled in the latest changes from 'master' to get it ready for merge. |
@kobik, Can you please review and merge this PR? |
@kobik, Is there anything else needed to get this PR merged? Please let me know. |
CI is currently misconfigured for the repo. |
@dipsmishra should be fixed now |
Any ideas? |
fixed according to this lemurheavy/coveralls-public#632. i don't like it too much as i was also required that it would allowed also in PR in order to work here. |
@kobik any update on pushing this PR through? |
Thank you! |
🎉 This PR is included in version 2.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This adds support for basic relative URLs in servers
Note: this still does not support variables/variable substitutions in URLs