Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for basic relative URLs in servers #67

Merged
merged 6 commits into from
May 11, 2021

Conversation

dipsmishra
Copy link
Contributor

This adds support for basic relative URLs in servers
Note: this still does not support variables/variable substitutions in URLs

This adds support for basic relative URLs in servers
* Note that this does not support variables/variable substitutions
@dipsmishra
Copy link
Contributor Author

This resolves #59

@dipsmishra dipsmishra marked this pull request as draft January 18, 2021 21:20
@dipsmishra dipsmishra marked this pull request as ready for review January 18, 2021 21:21
@dipsmishra
Copy link
Contributor Author

@kobik @kibertoad @tamlyn

Can one of you please review and merge if it looks good?
Thank you!

@deepakmonga2408
Copy link

Any update on this fix? This PR resolves the relative path errors and all tests pass. It would be great if you can review, merge and release.

@kobik
Copy link
Collaborator

kobik commented Jan 24, 2021

Hi @dipsmishra,

Thanks for the PR!

I hope I'll have the time to look on the nezt couple of days.

Copy link
Collaborator

@kobik kobik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dipsmishra !

@kobik
Copy link
Collaborator

kobik commented Feb 1, 2021

@dipsmishra can you please update CHANGELOG.md?

@dipsmishra
Copy link
Contributor Author

@dipsmishra can you please update CHANGELOG.md?

Yes, sure. Should I update the version in package.json to 2.0.5 too? I am not entirely sure about your release process and hence, checking.

@kobik
Copy link
Collaborator

kobik commented Feb 3, 2021

No need to update the json file as I use 'npm version' command for bumping and tagging before publishing it

@dipsmishra
Copy link
Contributor Author

Thanks for the clarification, @kobik - I have updated the PR accordingly and also pulled in the latest changes from 'master' to get it ready for merge.

@deepakmonga2408
Copy link

@kobik, Can you please review and merge this PR?

@dipsmishra
Copy link
Contributor Author

@kobik, Is there anything else needed to get this PR merged? Please let me know.

@kibertoad
Copy link
Collaborator

CI is currently misconfigured for the repo.
@kobik Could you please either drop travis and enable CircleCI for this repo (on their end, GitHub side is correct, I believe), or give me admin permissions for the repo so that I could do so?

@kobik
Copy link
Collaborator

kobik commented Feb 22, 2021

@dipsmishra should be fixed now

@kibertoad kibertoad closed this Feb 22, 2021
@kibertoad kibertoad reopened this Feb 22, 2021
@kibertoad
Copy link
Collaborator

@kobik

> api-schema-builder@2.0.4 coveralls /root/project
> cat ./coverage/lcov.info |./node_modules/.bin/coveralls


/root/project/node_modules/coveralls/bin/coveralls.js:19
      throw err;
      ^
Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}
(Use `node --trace-uncaught ...` to show where the exception was thrown)

Any ideas?
Wonder if we should disable coverage reporting for now to unblock the PR.

@kobik
Copy link
Collaborator

kobik commented Feb 22, 2021

fixed according to this lemurheavy/coveralls-public#632.

i don't like it too much as i was also required that it would allowed also in PR in order to work here.

@deepakmonga2408
Copy link

deepakmonga2408 commented Mar 19, 2021

@kobik any update on pushing this PR through?

@kibertoad kibertoad merged commit 4165d0e into PayU:master May 11, 2021
@kibertoad
Copy link
Collaborator

Thank you!

@github-actions
Copy link

🎉 This PR is included in version 2.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants