Don't skip parameter validation when parameter array is empty.

[wparad]

Parameter validation is ignored in the case when no parameters are specified. This is due to a bug here:

api-schema-builder/src/index.js

Line 125 in 5dff1ea

if (localParameters.length > 0 || options.contentTypeValidation) {

if (localParameters.length > 0 || options.contentTypeValidation) {
        requestSchema.parameters = buildParametersValidation(localParameters,
            dereferenced.paths[currentPath][currentMethod].consumes || dereferenced.paths[currentPath].consumes || dereferenced.consumes, options);
    }

Which incorrectly skips parameter building in case when there are no parameters and content type validation is not true. However parameters have nothing to do with content type, so this should always be done. Since content type validation is again checked there's no reason to do this check in this place:

api-schema-builder/src/index.js

Line 238 in 5dff1ea

ajvParametersSchema.properties.headers.content = createContentTypeHeaders(options.contentTypeValidation, contentTypes);

:

    ajvParametersSchema.properties.headers.content = createContentTypeHeaders(options.contentTypeValidation, contentTypes);

module.exports = function createContentTypeHeaders(validate, contentTypes) {
    if (!validate || !contentTypes) return;

    return {
        types: contentTypes
    };
};

[wparad]

@kobik, can we get a look at this?

[kobik]

Sure, will have a look

[kibertoad]

@wparad Could you please add test?

[wparad]

@kibertoad

@wparad Could you please add test?

I would, but I honestly can't figure out how in this repository to do that. If you could suggest a block of code I could copy and paste, I would be happy to.

[kibertoad]

@wparad Check this: https://github.com/PayU/api-schema-builder/blob/master/test/openapi2/request/request-oas2-test.js

[wparad]

@kibertoad 👍 added!

[github-actions]

🎉 This PR is included in version 2.0.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀