Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require source code based on whitelist only #60

Merged
merged 2 commits into from Apr 1, 2019
Merged

fix: require source code based on whitelist only #60

merged 2 commits into from Apr 1, 2019

Conversation

lirantal
Copy link
Collaborator

It is a potential security concern to require files dynamically.
In this case we can at least limit the module names to known frameworks and allowed source code files.

@lirantal lirantal self-assigned this Mar 22, 2019
@lirantal lirantal requested review from idanto and manorlh March 22, 2019 19:08
@coveralls
Copy link

coveralls commented Mar 22, 2019 •
edited

Coverage Status

Coverage increased (+0.007%) to 99.522% when pulling 3be5415 on lirantal:fix/require-base-on-whitelist into d5ce2b6 on Zooz:master.

@idanto
Copy link
Contributor

idanto commented Apr 1, 2019

Thanks @lirantal Looks good!!

@idanto idanto merged commit 62ee749 into PayU:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idanto idanto idanto approved these changes

@manorlh manorlh Awaiting requested review from manorlh

Assignees

@lirantal lirantal

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lirantal @coveralls @idanto