-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for prom-client v13 #65
Conversation
aea0063
to
1a1f9ed
Compare
1a1f9ed
to
2b1f11c
Compare
@kobik gently reminder :) would be great to merge this, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yorch!
Can you please add the breaking change to the Changelog file?
498b068
to
be7f5c9
Compare
@kobik sure.. done! |
@kobik thanks for the approval, unfortunately I cannot merge this as I don't have privileges. |
@yorch is like to merge and release both this and custom labels together, that's why I didn't merge it yet |
@kobik still not sure I follow, eventually you will have to merge one of these first and then the other. Most likely, one of these is gonna cause conflicts with the other that wont bubble up until one of these is merged |
@yorch , i've made some tests on my end and the current version works with both prom-client 12 and 13, so i think we can bump it by a minor version. what do you think? do you see a real reason for bumping a major version? |
@kobik agree, since there are not actual break changes then if it still works with 12, makes sense to keep the update as a minor version 👍 |
prom-client
v13 as it includes breaking changes (https://github.com/siimon/prom-client/releases/tag/v13.0.0)