Add checkout form as a service

[arkaitzgarro]

No description provided.

[mmoreram]

@arkaitzgarro Don't actually know what does PaypalWebCheckoutBundle has to do in this commit. Is empty!

Is this PR still in progress? If it is, could you please update the title of this Issue with [WIP] at the begining?

Ping me when ready :)

Thanks!

[arkaitzgarro]

Hi @mmoreram !

I tried to use this bundle in my project, but it seems that doesn't work at all. Have you tested or used it in any project?

The last commit of this PR should not be here. I started a new bundle to integrate Paypal web checkout, it's easier than express checkout to integrate and develop. It's working now, so maybe we could add to PaymentSuite. Take a look https://github.com/arkaitzgarro/PaypalWebCheckoutBundle

[mmoreram]

@arkaitzgarro Hi!

This bundle was developer by 2 or 3 devs some months ago but have been never used at all, neither tested. Lot of work just for one person :(

So that's awesome. Asap you finish this bundle, tested, I challenge to integrate it into Elcodi Bamboo Store :) How it sounds? Also, we can add it into PaymentSuite project, of course!

This enthusiasm is what all projects need, man. Yur awesome.

[mickaelandrieu]

👍 I initialy started this bundle but don't have time to finish it and don't have real e-commerce project at this time.

Then, others work on but don't push any commits ...
So, I'm OK with this new bundle (after a code review and tests).

Thank you @arkaitzgarro to have ended this work !

edit: maybe it's better to do an huge PR on the current repository ?

[dpcat237]

Hi!
Just this week I'll implement PayPal donation button in my project and will check if it has the same process or can be added as extra functionality in this bundle.

[mmoreram]

👍

[dpcat237]

PayPal donation button is easy to create as html button in PayPal web (with configuration of callback). That why I don't see necessary integrate in some bundle.

[sfblaauw]

Hi, like @arkaitzgarro said, this bundle doesn't work. I will like to integrate PapyPay payments to my application, but it seems there is no much work on it.
The PaypalWebCheckoutBundle of @arkaitzgarro will be integrate?
There is some future PayPal implementation?
I can help in anything?
Thanks

[mickaelandrieu]

ping @arkaitzgarro if you don't have time, I can add your modifications on the current PaypalBundle.

Let me know.

@sfblaauw did you have checked @arkaitzgarro implementation ?

edit: Wow i finaly understood. You don't have implemented Paypal Express Checkout but only Paypal Web checkout. @mmoreram : could be interesting to have this one if this is functional ;)

[sfblaauw]

Yes @mickaelandrieu, @arkaitzgarro don't implement the Paypal Express Checkout but, I think, is a good feature.
I just tested and it works but I think it has to have a refactoring. For example in PaypalWebCheckoutRoutesLoader the properties $this->controllerSuccessRoute and $this->controllerFailRoute doesn't exsits, throw an Exception

[mickaelandrieu]

Ok. @arkaitzgarro if you need help, contact me I can give you a hand for refactor/review.

Would you mind to give the ownership of the repository to payment suite ?

[arkaitzgarro]

Maybe the master branch is still a little buggy, as I've been working on the route-translation branch. @mickaelandrieu it will be great if you can take a look to the code. Let me transfer the repository.

[sfblaauw]

Awesome! One suggestion, it will be nice process response instead of rendering the template in PaypalWebCheckoutController:executeAction.
@arkaitzgarro, @mickaelandrieu if you need any help let me know.

[mickaelandrieu]

ping @mmoreram can we have a repository into paymentsuite to work on it please ?
PaypalWebCheckoutBundle according to @arkaitzgarro's contribution :)

[mmoreram]

Hi there!

As you can see, the packages are all in the same repository, PaymentSuite/PaymentSuite, so the main package should be in the big package.

I add you all as contributors with read/write access to the full package, but please... be responsible.

[mickaelandrieu]

@mmoreram thanks.
@arkaitzgarro please transfer ownership to the organization :)
Tomorrow I will review this one and probably add tests.

Let's go ^_^

[arkaitzgarro]

@mickaelandrieu the repository is already transfered and ready to test ;)
https://github.com/PaymentSuite/PaypalWebCheckoutBundle

[sfblaauw]

@mickaelandrieu are you working on it? I can do some work today and tomorrow. Please let me know.

[mickaelandrieu]

@sfblaauw not today, you can start to work I will consider and review all PR ASAP 👍

[sfblaauw]

@mickaelandrieu ok!