Bigfix/paymill js #28
Conversation
|
ping @tonipinel Could you please check this feature? :) EDIT: Already merged ;) Thanks @sfblaauw |
| if (oPaymill.bOkNumber !== true) { | ||
| var oLiNumber = document.createElement('li'); | ||
| oLiNumber.innerText = 'Card number invalid'; | ||
| oLiNumber.innerHTML = 'Card number invalid'; |
There was a problem hiding this comment.
You don't need to use innerHTML here because your content is not an HTML content
There was a problem hiding this comment.
innerText do not print anything
There was a problem hiding this comment.
my bad: it appears innerText is not a standard, this may explain why it's not printed (http://stackoverflow.com/a/19032002)
I suggest the use of textContent property :)
There was a problem hiding this comment.
oLiNumber.value? this will print <li value="0"></li>
There was a problem hiding this comment.
sorry @sfblaauw , updated my answer :D
|
@mickaelandrieu changed! |
|
@sfblaauw can you squash your commits ? Thank you for your fix :) |
sfblaauw
force-pushed
the
bigfix/paymill-js
branch
from
de4535b
to
d1d47d4
Compare
|
Done! |
|
@sfblaauw good job 👍 |
|
Thanks 🎉 |
No description provided.