Feature/gestpay #72
Feature/gestpay #72
Conversation
.gitignore
Outdated
| @@ -3,3 +3,5 @@ bin | |||
| composer.phar | |||
| composer.lock | |||
| phpunit.xml | |||
| .idea/ | |||
There was a problem hiding this comment.
this has to be part of your global ignore file. http://egorsmirnov.me/2015/05/04/global-gitignore-file.html
| </php> | ||
|
|
||
| <listeners> | ||
| <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener"> |
There was a problem hiding this comment.
This is mandatory for the ClockMock to work, i haven't tested it but it's said in the sf docs. However, i'm gonna check it and i'll tell you the results.
There was a problem hiding this comment.
Yeah, this is needed. We need to configure de namespaces for the ClockMock, without that it does not work properly.
| phpunit.xml | ||
|
|
||
| # Editors | ||
| .idea/* |
| </filter> | ||
|
|
||
| <php> | ||
| <env name="GESTPAY_SHOP_LOGIN" value="GESPAYXXXX"/> |
There was a problem hiding this comment.
have you added the keys to travis?
| @@ -72,7 +72,7 @@ public function executeAction() | |||
| return new Response( | |||
| $this | |||
| ->templatingEngine | |||
| ->render('RedsysBundle:Redsys:process.html.twig', [ | |||
| ->render('GestpayBundle:Redsys:process.html.twig', [ | |||
There was a problem hiding this comment.
I think the refactor command does something wrong here :-P
There was a problem hiding this comment.
Hmmm yeah it seems so, I was not aware of this. I'll change it and pass the whole test suite
| @@ -18,7 +18,7 @@ | |||
| use PaymentSuite\PaymentCoreBundle\PaymentMethodInterface; | |||
|
|
|||
| /** | |||
| * RedsysMethod class. | |||
| * GestPayMethod class. | |||
| @@ -38,7 +38,7 @@ class RedsysManager | |||
| /** | |||
| * @var RedsysMethodFactory | |||
| * | |||
| * RedsysMethod factory | |||
| * GestPayMethod factory | |||
| @@ -67,7 +67,7 @@ class RedsysManager | |||
| * Construct method for redsys manager. | |||
| * | |||
| * @param RedsysFormTypeBuilder $redsysFormTypeBuilder Form Type Builder | |||
| * @param RedsysMethodFactory $redsysMethodFactory RedsysMethod factory | |||
| * @param RedsysMethodFactory $redsysMethodFactory GestPayMethod factory | |||
sangarbe
force-pushed
the
feature/gestpay
branch
from
86397ac
to
f37531c
Compare
No description provided.