Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to the Settings Tabs translation situation + Fixes to spanish translation #282

Merged
merged 12 commits into from
Dec 13, 2023

Conversation

mendozal
Copy link
Contributor

@mendozal mendozal commented Dec 3, 2023

I created a dev environment and ran
npx laravel-language-extractor --theme default and translated the new strings.

ALSO

I added a fix to themes/default/views/admin/settings/index.blade.php allowing the translation of the settings tabs.
In order for this to work we should add the following lowercase key, value pairs to the language's json files:

"general": "general",
"affiliate": "afiliados",
"company": "empresa",
"credits": "créditos",
"cronjob": "cronjob",
"login": "login",
"mail": "mail",
"security": "seguridad",
"theme": "tema",
"upgrade": "actualizar"

I added them to the Spanish version, but I don't want to mess with the other languages.

I belive, npx laravel-language-extractor --theme default won't retrieve them because they're a dynamic value.

@mendozal
Copy link
Contributor Author

mendozal commented Dec 3, 2023

Let me know if you'd like me to add the missing keys to the other language files (without translating them), so they're available to others.

@CorwinDev
Copy link
Member

Let me know if you'd like me to add the missing keys to the other language files (without translating them), so they're available to others.

Yes please

@mendozal
Copy link
Contributor Author

Added the labels to the other languages, but didn't sort the JSON files because VSCode sorts differently and creates many unnecessary changes to the files.

@CorwinDev CorwinDev merged commit 23445b0 into Paymenter:master Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants