Fix to the Settings Tabs translation situation + Fixes to spanish translation #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a dev environment and ran
npx laravel-language-extractor --theme default
and translated the new strings.ALSO
I added a fix to
themes/default/views/admin/settings/index.blade.php
allowing the translation of the settings tabs.In order for this to work we should add the following lowercase key, value pairs to the language's json files:
I added them to the Spanish version, but I don't want to mess with the other languages.
I belive,
npx laravel-language-extractor --theme default
won't retrieve them because they're a dynamic value.