Add fields to set stripe variables for allow remember me and email #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierredup
reviewed
Mar 22, 2021
| @@ -12,6 +12,8 @@ | |||
| data-description="{{ model.description|default("") }}" | |||
| data-amount="{{ model.amount }}" | |||
| data-currency="{{ model.currency|default("USD") }}" | |||
| data-allowRememberMe="{{ model.local.allowRememberMe|default("false") }}" | |||
| data-email="{{ model.local.email|default("") }}" | |||
There was a problem hiding this comment.
Are these options still valid? I can't find anything about these options in the docs. It might only be relevant for an older version of Stripe
There was a problem hiding this comment.
Yes the version of stripe checkout built into Payum is the legacy version, and the new version of stripe checkout is quite different.
It isn't a direct upgrade from what I can see, for simply taking payments. I just recently wrote a payment method using Stripe Elements to do a simple payment - https://github.com/joshbmarshall/payum_stripe
pierredup
added
integration
pierredup
pushed a commit
to aliriaz-stripe/Payum
that referenced
this pull request
Dec 3, 2021
…ayum#842) Co-authored-by: Josh Marshall <josh@jmarshall.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.