Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twig 3 and fix tests #861

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Twig 3 and fix tests #861

merged 3 commits into from
Oct 20, 2020

Conversation

StudioMaX
Copy link
Contributor

@StudioMaX StudioMaX commented Sep 9, 2020 •
edited

Compatibility with Twig 3.

Closes #840, also closes #863

@StudioMaX StudioMaX changed the title Twig 3 Twig 3 and fix tests Sep 9, 2020
@davidmpaz
Copy link

davidmpaz commented Sep 27, 2020 •
edited

Hopefully, this will get merge soon.

@Tetragramat , @joshbmarshal Would any of you like to take a look into this. To notify for merging after all is done?

Thanks in advance,
David

@davidmpaz davidmpaz mentioned this pull request Oct 1, 2020
Closed
davidmpaz
davidmpaz suggested changes Oct 1, 2020
View reviewed changes
Copy link

@davidmpaz davidmpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @StudioMaX,

I made some review and added some comments about the usage of string to refer to class names instead using the static class attribute. would you mid please to provide some feedback. I believe afterward this PR can be merged.

Thanks in advance,
David

src/Payum/Core/Registry/AbstractRegistry.php Show resolved Hide resolved
src/Payum/Core/Tests/Bridge/Doctrine/Storage/DoctrineStorageTest.php Outdated Show resolved Hide resolved
@BoShurik BoShurik mentioned this pull request Oct 7, 2020
Closed
@BoShurik
Copy link
Contributor

BoShurik commented Oct 8, 2020

Can you change .travis.yml like this to check tests with lower dependencies?

@StudioMaX
Copy link
Contributor Author

@BoShurik ok, I've added this lower dependency check.

@cariba
Copy link

cariba commented Oct 13, 2020

Thank you @StudioMaX for this great fix!
Any idea when it will be available?
We're all in SF 5 and Twig 3 so we can't use payum without this being merged.

@davidmpaz
Copy link

Hi @makasim,

this was approved already. If no more TODOs left, would you like to merge it please?

thanks in advance and regards,
David

@makasim makasim merged commit b9935e9 into Payum:master Oct 20, 2020
@StudioMaX StudioMaX deleted the twig3 branch October 20, 2020 06:35
@pierredup pierredup mentioned this pull request Feb 26, 2021
Open
@pierredup pierredup mentioned this pull request Mar 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmpaz davidmpaz davidmpaz requested changes

@Tetragramat Tetragramat Tetragramat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing dependency on doctrine/persistence ^1.0 Twig 3.x compatibility
6 participants
@StudioMaX @davidmpaz @BoShurik @cariba @Tetragramat @makasim