-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge service libraries into one repository and use git tree split #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small Fixes that bugger me a lot...
Mongodb odm support added
[Minor] Typo fixed
implement mongodb mapping for payment details
makasim
added a commit
that referenced
this pull request
Dec 3, 2013
[RFC] Merge service libraries into one repository and use git tree split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO it starts to be annoying that every payment has own repository & is not any way to get all of them in one time, also most of those implementation are really similar when you compare code bases...
What I'm suggesting is a merge into main repo all of those (could be hard to maintain at some point), or create new repository, i.e.
PayumGateway
(or something) and merge all those currently separated repositories (AuthorizeNetAim
,Be2Bill
etc.).With this approch you could have in main catalog an
composer.json
file:All gateways would be store i.e.
Payum\Gateway\Be2Bill
, and on that folder it will be same as actual content of repository with git tree split.The approach is same as used by Symfony or Sylius.