feat: php 7.4 features and typehints #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pierredup
reviewed
Feb 27, 2022
There was a problem hiding this comment.
There's a few BC breaks which I think should be reverted, but otherwise the changes looks great.
There are also some failing unit tests that seems related to these changes (but can wait for #536 to be merged so that the rest of the builds can pass)
Chris53897
changed the title
|
Can you pleasse check if all BC Breaks are removed now? |
|
Thank you @Chris53897 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add php 7.4 features.
Add typehints
Remove wrong (According to PhpStorm) and useless DocBlocks Comments
DI for Payum (container->get() is deprecated and removed in Symfony 6).
This needs to be tested. But tests do not work correct.
Payum\Core\Payum vs Payum\Core\Registry\RegistryInterface in Commands? See old DocBlock return hints.
So this should be merged upfront #536