added support for parsing esp packets #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricknerb
requested changes
Jun 21, 2019
| /// </summary> | ||
| public Datagram Payload | ||
| { | ||
| get { return new Datagram(Buffer, StartOffset + HeaderLength, Length - HeaderLength); } |
There was a problem hiding this comment.
Wouldn't that include the pading, pad length, next header and ICV?
There was a problem hiding this comment.
- Could you add tests? See GreTests and WiresharkCompareTests.
- Could you add EspLayer?
I have different nits to make the style conform better with the rest of the code, let me know if you'd like me to add comments or I can just fix it after this is merged.
Thanks for checking out my PR. I'll continue working on this.
There was a problem hiding this comment.
Wouldn't that include the pading, pad length, next header and ICV?
I tried to replicate the way Wireshark parses these packets. It includes all of this data in the payload.
There was a problem hiding this comment.
Great, let me know when you want me to take another look.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.