Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'All relatives' often fails #2

Closed
waldemar-szostak opened this issue Oct 8, 2019 · 3 comments
Closed

'All relatives' often fails #2

waldemar-szostak opened this issue Oct 8, 2019 · 3 comments

Comments

@waldemar-szostak
Copy link

waldemar-szostak commented Oct 8, 2019

Hello,
First off, thank you very much for this great visualisation tool. It's almost exactly what I need :)

Unfortunately, there are some glitches in it, such as when selecting 'All relatives'. Surprisingly it always does work for some nodes (persons in the tree), but for most of them - it does not.

Exception #1

relatives-chart.js:202 Uncaught TypeError: Cannot read property 'width' of undefined
at relatives-chart.js:202
at h.each (each.js:13)
at t.layOutAncestorDescendants (relatives-chart.js:170)
at t.render (relatives-chart.js:257)
at t.render (simple-api.js:66)
at t.value (chart.tsx:153)
at t.value (chart.tsx:218)
at qa (react-dom.production.min.js:4980)
at Wa (react-dom.production.min.js:5123)
at react-dom.production.min.js:5975
(anonymous) @ relatives-chart.js:202
each @ each.js:13
t.layOutAncestorDescendants @ relatives-chart.js:170
t.render @ relatives-chart.js:257
t.render @ simple-api.js:66
value @ chart.tsx:153
value @ chart.tsx:218
qa @ react-dom.production.min.js:4980
Wa @ react-dom.production.min.js:5123
(anonymous) @ react-dom.production.min.js:5975
e.unstable_runWithPriority @ scheduler.production.min.js:274
Ps @ react-dom.production.min.js:5974
Ts @ react-dom.production.min.js:5958
Cs @ react-dom.production.min.js:5925
Is @ react-dom.production.min.js:6020
On @ react-dom.production.min.js:1737

Exception #2

react-dom.production.min.js:4408 TypeError: Cannot read property 'width' of undefined
at relatives-chart.js:202
at h.each (each.js:13)
at t.layOutAncestorDescendants (relatives-chart.js:170)
at t.render (relatives-chart.js:257)
at t.render (simple-api.js:66)
at t.value (chart.tsx:153)
at t.value (chart.tsx:218)
at qa (react-dom.production.min.js:4980)
at Wa (react-dom.production.min.js:5123)
at react-dom.production.min.js:5975

Browser: Chromium Wersja 76.0.3809.132 (Oficjalna wersja) Arch Linux (64-bitowa)

The GEDCOM I used: https://drive.google.com/open?id=1oroSZAhNPa5DkeVdbDcQt_I-uj08pZNa

Steps to reproduce:

  1. Open the file linked.
  2. Switch to 'Show all relatives'.

Interestingly - if you select 'Ignacy Wylęga' node, then the show All relatives option works fine.

PeWu added a commit that referenced this issue Oct 10, 2019
@PeWu
Copy link
Owner

PeWu commented Oct 10, 2019

Thanks for the report and detailed repro instructions.
The described issue (load the supplied ged file and switch to 'all relatives') is now fixed. Let me know if there are other cases that still fail.

@PeWu
Copy link
Owner

PeWu commented Oct 17, 2019

Closing for now. Reopen if you find a reproducible failure.

@PeWu PeWu closed this as completed Oct 17, 2019
@waldemar-szostak
Copy link
Author

Yes, it works. Thanks for the quick fix and apologies for the late feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants