Remove use of Pkg.BinaryPlatforms types for dispatch #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4
Basically, we want to remove use of the Linux, Windows, and MacOS types from Pkg.BinaryPlatforms.
Instead, we dispatch on
Val(Symbol(Base.BinaryPlatforms.os(platform)))
. This allows us tokeep the current dispatch pattern and be backwards compatible with the use of
Pkg.BinaryPlatforms.{Linux, Windows, MacOS}
. However, we no longer rely on those types for dispatch.