Improve test shell scripts #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairchu
requested changes
Jul 25, 2023
The command printing (-x) is needed for all the tests. The short form is more readable.
Makes it easier to override which git-mediate will be run, especially in automatic tests of distro packages.
The == operator is undefined in POSIX shell. Suggested-by: shellcheck See-also: https://www.shellcheck.net/wiki/SC3014
Otherwise they will be subject to globbing and word splitting. Suggested-by: shellcheck See-also: https://www.shellcheck.net/wiki/SC2086
Suggested-by: shellcheck See-also: https://www.shellcheck.net/wiki/SC2250
Avoids altering developer home directories when running tests that alter the per-user git configuration files.
Avoids overly long lines. Suggested-by: bashate
This allows them to be run directly instead of be prefixed with the shell. They are now POSIX shell scripts so use /bin/sh as the shell interpreter.
This way they show up as strings in editor syntax highlighting.
The trap builtin sets a cleanup function to be run at exit. Call the cleanup function before the tests start too. Add more files to be cleaned up too.
|
In the process of reviewing the test output, I noticed a bug around handling of whitespace chars in filenames (#45). Unfortunately that didn't cause failure of the |
yairchu
approved these changes
Jul 25, 2023
|
Thanks!
It's good to know that there's a |
|
Thanks for merging and looking into the spaces issue and NUL option.
…--
bye,
pabs
https://bonedaddy.net/pabs3/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set -euxfor all test shell scripts$PATHinstead of a location stored in a variable=instead of==within[ ]tests