Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: controlled component #8

Merged
merged 2 commits into from
Aug 1, 2017
Merged

feat: controlled component #8

merged 2 commits into from
Aug 1, 2017

Conversation

nlkluth
Copy link
Contributor

@nlkluth nlkluth commented Aug 1, 2017

  • moved AlertList to a separate component so console can control what gets displayed
  • made it so console can pass in translation message objects and Alert will put them into a FormattedMessage. Not sure what y'all think of that.
  • added tests. for some reason jest.fn wasn't a thing 🤷‍♂️

@eajazali87
Copy link
Contributor

ok enough approvals, merging it.

@eajazali87 eajazali87 merged commit 36c5adb into master Aug 1, 2017
@nlkluth nlkluth deleted the controlled-component branch August 1, 2017 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants