Fixed Issue with macOS build using 'd:lto' flag + Added support for *.nim.cfg and *.nims files to specify compiler flags. + Amended the README see #52
#55
Conversation
… and 'nims' file.
…correctly detected.
… correctly detected.
…d references to `*.nim.cfg` or `*.nims`.
# Conflicts: # tests/test_distribution.py
…etup-nim-action@v1.3.
SekouDiaoNlp
added
bug
…e_nim_code(). + Added docstrings for all the new methods.
…alled at build time. See issue #52.
… conventions. + Amended documentation to reflect the change.
… World!\n' == 'Hello World!\r\n'" when using the latest version of pytest.
Uses poetry as a build backend and mypy as a type checker.
… conventions. + Amended documentation to reflect the change.
…of values from 'str' to 'Path' and vice versa.
…mporter from same directory.
|
Hi @Pebaz, what's up? I am done implementing all the changes and testing them. I completely refactored the code in On the developer side, I fully type annotated The README has been updated to reflect all the changes. I'll monitor the progress of the worflow checks (I guess I went a bit overboard with the number of jobs in the matrix on the last tweak to the workflows lol. I will trim the amount of jobs testing the pyproject.toml stuff) Let me know what you think. SekouDiaoNlp. |
|
I trimmed the number of poetry builds to a more reasonable number. |
|
LGTM 👍🏿 |
|
This is fantastic work for real. |
Thank you for the kind words. Take your time and keep me updated. Peace. |
SekouDiaoNlp
changed the title
*.nim.cfg and *.nims files to specify compiler flags.*.nim.cfg and *.nims files to specify compiler flags. + Amended the README see #52
There was a problem hiding this comment.
@SekouDiaoNlp I looked through all your changes. Absolutely amazing work! 🚀 This was a large refactor and I think you've done an exemplary job getting it done quickly with high quality. The changes that help to modernize Nimporter are awesome and helps to increase the longevity of the project as a whole.
Thanks for fixing these issues, have a fantastic day, and congrats on the big refactor! 😃🎉
|
Hey @Pebaz! I am glad that my work was useful and is valued. I have had a few ideas for new features after I delved deep in nimporter. I will write a post in the discussion section of the repository to share them with you beginning of next week. And it's cool to be able to contribute back to a project that is useful to me in various projects. Have a great evening! ✌️ |
Hi @Pebaz ,
As discussed previously, this PR adds the following changes.
*.nim.cfgand*.nimsfiles to specify Nim compiler flags. See discussion Add support for overriding default compiler flags with '.nim.cfg' and '.nims' configuration files #54 for details.switches.pyswitches.pyis detected.switches.pySource Distributionto fix error in specifying chosenim_install dependency. See Clarification request concerningchoosenim_install#52.I also added a new workflow to test nimporter on more versions of Python and Nim.
All tests pass on every system apart from nim version 1.5 because jiro4989/setup-nim-action fails to install this nim version through choose-nim.
I checked their repository and did not see any open issue regarding this so I might open one myself while I keep investigating.
Waiting for your feedback.
Peace.
SekouDiaoNlp.