Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a file extension that will be recognized as pebble #553

Closed
xenoterracide opened this issue Dec 4, 2020 · 13 comments
Closed

add a file extension that will be recognized as pebble #553

xenoterracide opened this issue Dec 4, 2020 · 13 comments
Milestone

Comments

@xenoterracide
Copy link

using pebble to generate non web files, would be useful to have an extension that could be used to also recognize as pebble, for example in intellij's plugin. This is more of a doc, spec, spread the word thing.

@ebussieres
Copy link
Member

Not sure to understand. You can already change the suffix for pebble's template.

@xenoterracide
Copy link
Author

an IDE can't recognize a file as a pebble template if it's not say, html.

@ebussieres
Copy link
Member

If you're using IntelliJ, I suggest that you log an issue here. This repo does not provide IDE support

https://github.com/bjansen/pebble-intellij

@xenoterracide
Copy link
Author

the point of this issue is to have a standard extension name so any ide could use that to recognize it. but if you're not willing feel free to close it.

@ebussieres
Copy link
Member

ebussieres commented Dec 4, 2020

If you are using spring boot, default extension is .pebble

@xenoterracide
Copy link
Author

xenoterracide commented Dec 7, 2020

is this the default extension of pebble itself? does this mean that getTemplate with FileLoader does not require the extension when looking up the string? I've opened an issue bjansen/pebble-intellij#56

@xenoterracide
Copy link
Author

xenoterracide commented Dec 7, 2020

the intellij bug says that it's .peb that is supported by default, so by not documenting this there are already 2 different file extensions used, and this is difficult to discover as a developer.

@bjansen
Copy link
Contributor

bjansen commented Dec 7, 2020

Most of the unit tests, documentation and Javadoc in this repo use the .peb extension, although it's not documented as the 'official' extension. I'm a little surprised you guys decided to use .pebble in the Spring Boot starter actually.

@xenoterracide
Copy link
Author

you guys decided to use .pebble in the Spring Boot started actually

I don't know, but this sort of confusion is why I'm asking it to be documented.

@ebussieres
Copy link
Member

Ok I'll change default extension suffix in spring boot to .peb in version 3.2

@ebussieres ebussieres added this to the 3.2.0 milestone Dec 8, 2020
@bjansen
Copy link
Contributor

bjansen commented Dec 8, 2020

Won't this break projects that don't customize the default settings when they upgrade to 3.2?

@ebussieres
Copy link
Member

That's why I intend to make this change in 3.2.x and not in 3.1.x branch

@ebussieres
Copy link
Member

Gonna be available in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants