Allow keyless guests #606
Merged
Allow keyless guests #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlebauer
approved these changes
Nov 26, 2018
robkooper
requested changes
Nov 27, 2018
| if key.nil? | ||
| u = User.find_by_login('guestuser') | ||
| else | ||
| u = User.find_by_apikey(params[:key]) || User.find_by_login('guestuser') |
There was a problem hiding this comment.
If a key is given and it is wrong, I think it should return an error that states it is an invalid login. Otherwise the user might be confused why their login does not allow them to do certain actions in case the API is wrong (since it becomes guestuser).
…est user account.
robkooper
reviewed
Nov 27, 2018
|
|
||
| if u.nil? | ||
| @errors = "You must either use a valid API key or set up the guest user account." | ||
| u = User.find_by_apikey(params[:key]) |
There was a problem hiding this comment.
nitpicking but can use key variable here to prevent an extra lookup.
There was a problem hiding this comment.
No problem--that was my intention but then I forgot to; and your nitpicking led me to notice and fix a more serious problem.
robkooper
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements feature requested in Issue #605.