Merge pull request #2552 from infotroph/dont-build-query

remove build_insert_query, use dbAppendTable directly

CHANGELOG.md

@@ -20,6 +20,7 @@ For more information about this file see also [Keep a Changelog](http://keepacha
 - When building sipnet model would not set correct model version
 
 ### Changed
+- `PEcAn.DB::insert_table` now uses `DBI::dbAppendTable` internally instead of manually constructed SQL (#2552).
 - Rebuilt documentation using Roxygen 7. Readers get nicer formatting of usage sections, writers get more flexible behavior when inheriting parameters and less hassle when maintaining namespaces (#2524).
 - Renamed functions that looked like S3 methods but were not:
     * PEcAn.priors: `plot.posterior.density`->`plot_posterior.density`, `plot.prior.density`->`plot_prior.density`, `plot.trait`->`plot_trait` (#2439).

base/db/R/insert_table.R

@@ -20,8 +20,8 @@
 #' dplyr::tbl(irisdb, "iris")
 insert_table <- function(values, table, con, coerce_col_class = TRUE, drop = TRUE) {
   values_fixed <- match_dbcols(values, table, con, coerce_col_class, drop = TRUE)
-  insert_query <- build_insert_query(values_fixed, table, .con = con)
-  db.query(insert_query, con)
+
+  DBI::dbAppendTable(con, table, values_fixed)
 }
 
 #' Match column names and classes between local and SQL table
@@ -91,22 +91,3 @@ match_colnames <- function(values, table, con) {
   values_cols <- colnames(values)
   intersect(values_cols, table_cols)
 }
-
-#' Build query to insert R data frame into SQL table
-#'
-#' @inheritParams insert_table
-#' @inheritParams glue::glue_sql
-build_insert_query <- function(values, table, .con) {
-  value_list <- purrr::map(seq_len(nrow(values)), ~as.list(values[.x, ]))
-
-  insert_list <- value_list %>%
-    purrr::map(unname) %>%
-    purrr::map(dbplyr::escape, con = .con) %>%
-    purrr::map(dbplyr::sql_vector, con = .con)
-
-  glue::glue_sql(
-    "INSERT INTO {`table`} ({`colnames(values)`*}) ",
-    "VALUES {insert_list*}",
-    .con = .con
-  )
-}